713 examples - move readmes to docusaurus#209
Conversation
There was a problem hiding this comment.
It's looking great! It's working functionally, but context-wise, we need to make some updates since we are no longer referencing the repo.
Each example markdown file has the same paragraph that references the repo, so we should remove those(for example https://github.com/NMFS-RADFish/radfish/pull/209/changes#diff-b761abd9e776de19d2d85d567b6b2b6fd4addebda3eba53a209ff9fb019eeb87R11)
docs/developer-documentation/examples-and-templates/examples/computed-form-fields.md
Outdated
Show resolved
Hide resolved
jaygiang
left a comment
jaygiang
left a comment
There was a problem hiding this comment.
It's looking good!
A couple things I noticed that we should clean up:
- Lets uninstall
docusaurus-plugin-remote-contentpackage. Please run
npm uninstall docusaurus-plugin-remote-content
- We can remove
readmeToNamedMdfunction since it's no longer used
|
Thank you for the guidance! Just checking, should I keep re-requesting the review once I make any requested changes? |
np! Yup you can keep re-requesting. |
2 participants
No description provided.